[GRASS-QA] GRASS QA: markus | ./grass6/lib/ogsf/gvl_calc.c |no clones | 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/ogsf/gvl_calc.c functions


iso_w_cndx (Begins at: 64 Ends at: 85)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

iso_r_cndx (Begins at: 89 Ends at: 108)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

iso_get_cube_value (Begins at: 112 Ends at: 147)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

iso_get_range (Begins at: 151 Ends at: 154)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

iso_get_cube_values (Begins at: 158 Ends at: 169)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

iso_get_cube_grads (Begins at: 173 Ends at: 232)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      18 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

iso_calc_cube (Begins at: 236 Ends at: 439)
--------------+---------+-------+---------+
Complexity:   |      35 |    ** | Warning |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      46 |     * |         |
LOC:          |     204 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

gvl_isosurf_calc (Begins at: 443 Ends at: 576)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |     134 |     * |         |
--------------+---------+-------+---------+
metrics are OK

gvl_write_char (Begins at: 579 Ends at: 598)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gvl_read_char (Begins at: 601 Ends at: 604)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gvl_align_data (Begins at: 607 Ends at: 632)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

slice_get_value (Begins at: 634 Ends at: 659)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

slice_calc (Begins at: 662 Ends at: 808)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      21 |       |      OK |
LOC:          |     147 |     * |         |
--------------+---------+-------+---------+
metrics are OK

gvl_slices_calc (Begins at: 811 Ends at: 843)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      33 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-08-23 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html