[GRASS-QA] GRASS QA: glynn | ./grass6/lib/raster/loc_proto.c |6
clones ( main.c command.c Draw.c com_proto.c loc_proto.c )| 0
monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Aug 30 15:04:09 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/raster/loc_proto.c functions
LOC_screen_left (Begins at: 25 Ends at: 41)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_screen_rite (Begins at: 43 Ends at: 59)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_screen_bot (Begins at: 61 Ends at: 78)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_screen_top (Begins at: 80 Ends at: 87)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_get_num_colors (Begins at: 89 Ends at: 107)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_color_table_float (Begins at: 109 Ends at: 125)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_color_table_fixed (Begins at: 127 Ends at: 130)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_color_offset (Begins at: 132 Ends at: 147)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_color (Begins at: 149 Ends at: 166)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_standard_color (Begins at: 168 Ends at: 187)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_RGB_color (Begins at: 189 Ends at: 207)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_reset_color (Begins at: 209 Ends at: 233)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_reset_colors (Begins at: 235 Ends at: 250)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_line_width (Begins at: 252 Ends at: 266)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_erase (Begins at: 268 Ends at: 284)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_move_abs (Begins at: 286 Ends at: 306)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_move_rel (Begins at: 308 Ends at: 325)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_cont_abs (Begins at: 327 Ends at: 349)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_cont_rel (Begins at: 351 Ends at: 369)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polydots_abs (Begins at: 371 Ends at: 391)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polydots_rel (Begins at: 393 Ends at: 414)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polyline_abs (Begins at: 416 Ends at: 438)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polyline_rel (Begins at: 440 Ends at: 458)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polygon_abs (Begins at: 460 Ends at: 480)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polygon_rel (Begins at: 482 Ends at: 501)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_box_abs (Begins at: 503 Ends at: 521)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_box_rel (Begins at: 523 Ends at: 538)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_text_size (Begins at: 540 Ends at: 545)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_text_rotation (Begins at: 547 Ends at: 565)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_set_window (Begins at: 567 Ends at: 582)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_text (Begins at: 584 Ends at: 606)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_get_text_box (Begins at: 608 Ends at: 613)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
select_font (Begins at: 615 Ends at: 657)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_font (Begins at: 659 Ends at: 665)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_font_freetype (Begins at: 667 Ends at: 670)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_charset (Begins at: 672 Ends at: 675)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_font_freetype_release (Begins at: 677 Ends at: 680)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_panel_save (Begins at: 682 Ends at: 690)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 4 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_panel_restore (Begins at: 692 Ends at: 698)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_panel_delete (Begins at: 700 Ends at: 724)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_set_RGB_color (Begins at: 726 Ends at: 754)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_RGB_raster (Begins at: 756 Ends at: 794)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 39 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_raster_char (Begins at: 796 Ends at: 801)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_raster_int (Begins at: 803 Ends at: 808)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_bitmap (Begins at: 810 Ends at: 815)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
LOC_polydots_rel LOC_screen_rite LOC_screen_left LOC_polyline_abs LOC_text_rotation LOC_get_num_colors
In lib/raster/loc_proto.c clones of LOC_polyline_abs are:
lib/gis/cats.c G_mark_f_raster_cats
lib/gis/cats.c G_mark_c_raster_cats
In lib/raster/loc_proto.c clones of LOC_text_rotation are:
lib/raster/loc_proto.c LOC_get_num_colors
In lib/raster/loc_proto.c clones of LOC_polydots_rel are:
lib/gis/cats.c G_init_cats
In lib/raster/loc_proto.c clones of LOC_screen_rite are:
lib/raster/loc_proto.c LOC_screen_left
In lib/raster/loc_proto.c clones of LOC_screen_left are:
lib/raster/loc_proto.c LOC_screen_rite
In lib/raster/loc_proto.c clones of LOC_get_num_colors are:
lib/raster/loc_proto.c LOC_text_rotation
__________________________________________
Threshold GRASS6 key metrics values at 2006-08-30 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 36 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 80 |
LOC: 39 | 179 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list