[GRASS-QA] GRASS QA: glynn | ./grass6/lib/driver/command.c |8 clones ( main.c command.c )| 3 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/driver/command.c functions


xalloc (Begins at: 58 Ends at: 67)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

command_init (Begins at: 69 Ends at: 78)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

LIB_command_get_input (Begins at: 80 Ends at: 83)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

process_command (Begins at: 85 Ends at: 618)
--------------+---------+-------+---------+
Complexity:   |     218 |   *** | MONSTER |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |     283 |   *** | MONSTER |
LOC:          |     534 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

read1 (Begins at: 620 Ends at: 633)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_command (Begins at: 635 Ends at: 661)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get1 (Begins at: 663 Ends at: 678)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

rec (Begins at: 680 Ends at: 689)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

rectext (Begins at: 691 Ends at: 715)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

_send (Begins at: 717 Ends at: 733)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sendtext (Begins at: 735 Ends at: 739)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

RESULT (Begins at: 741 Ends at: 749)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 8 potentially cloned functions:
  get_command  rec  get1  command_init  rectext  xalloc  process_command  read1

In lib/driver/command.c clones of  xalloc are:
	display/drivers/lib/command.c  xalloc

In lib/driver/command.c clones of  read1 are:
	display/drivers/lib/command.c  read1

In lib/driver/command.c clones of  get_command are:
	display/drivers/lib/command.c  get_command

In lib/driver/command.c clones of  process_command are:
	display/drivers/lib/command.c  process_command

In lib/driver/command.c clones of  rectext are:
	display/drivers/lib/command.c  rectext

In lib/driver/command.c clones of  get1 are:
	display/drivers/lib/command.c  get1

In lib/driver/command.c clones of  command_init are:
	display/drivers/lib/command.c  command_init

In lib/driver/command.c clones of  rec are:
	display/drivers/lib/command.c  rec


__________________________________________

Threshold GRASS6 key metrics values at 2006-08-30 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html