[GRASS-QA] GRASS QA: jachym | ./grass6/raster/r.topmodel/file_io.c |no clones | 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello jachym,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.topmodel/file_io.c functions


get_line (Begins at: 6 Ends at: 20)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_inputs (Begins at: 24 Ends at: 189)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      49 |     * |         |
LOC:          |     166 |     * |         |
--------------+---------+-------+---------+
metrics are OK

write_outputs (Begins at: 193 Ends at: 413)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      84 |    ** | Warning |
LOC:          |     221 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-12-09 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html