[GRASS-QA] GRASS QA: brad | ./grass6/lib/gis/alloc_cell.c |4 clones ( alloc_cell.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/alloc_cell.c functions


G_raster_size (Begins at: 22 Ends at: 45)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_allocate_cell_buf (Begins at: 48 Ends at: 60)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_allocate_raster_buf (Begins at: 63 Ends at: 76)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_allocate_c_raster_buf (Begins at: 79 Ends at: 91)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_allocate_f_raster_buf (Begins at: 94 Ends at: 106)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_allocate_d_raster_buf (Begins at: 109 Ends at: 121)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_allocate_null_buf (Begins at: 124 Ends at: 127)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G__allocate_null_bits (Begins at: 130 Ends at: 135)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G__null_bitstream_size (Begins at: 138 Ends at: 143)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  G_allocate_d_raster_buf  G_allocate_f_raster_buf  G_allocate_c_raster_buf  G_allocate_cell_buf

In lib/gis/alloc_cell.c clones of  G_allocate_f_raster_buf are:
	lib/gis/alloc_cell.c  G_allocate_d_raster_buf
	lib/gis/alloc_cell.c  G_allocate_c_raster_buf
	lib/gis/alloc_cell.c  G_allocate_cell_buf

In lib/gis/alloc_cell.c clones of  G_allocate_cell_buf are:
	lib/gis/alloc_cell.c  G_allocate_d_raster_buf
	lib/gis/alloc_cell.c  G_allocate_f_raster_buf
	lib/gis/alloc_cell.c  G_allocate_c_raster_buf

In lib/gis/alloc_cell.c clones of  G_allocate_c_raster_buf are:
	lib/gis/alloc_cell.c  G_allocate_d_raster_buf
	lib/gis/alloc_cell.c  G_allocate_f_raster_buf
	lib/gis/alloc_cell.c  G_allocate_cell_buf

In lib/gis/alloc_cell.c clones of  G_allocate_d_raster_buf are:
	lib/gis/alloc_cell.c  G_allocate_f_raster_buf
	lib/gis/alloc_cell.c  G_allocate_c_raster_buf
	lib/gis/alloc_cell.c  G_allocate_cell_buf


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-22 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html