[GRASS-QA] GRASS QA: markus | ./grass6/vector/v.in.ascii/points.c |no clones | 2 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.in.ascii/points.c functions


is_int (Begins at: 12 Ends at: 20)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

is_double (Begins at: 24 Ends at: 46)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

points_analyse (Begins at: 48 Ends at: 194)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |      11 |   *** | MONSTER |
CalledNBR:    |      39 |     * |         |
LOC:          |     147 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

points_to_bin (Begins at: 196 Ends at: 307)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |      13 |   *** | MONSTER |
CalledNBR:    |      51 |     * |         |
LOC:          |     112 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-07-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html