[GRASS-QA] GRASS QA: glynn | ./grass6/visualization/nviz/src/togl_flythrough.c |1 clones ( togl.c togl_flythrough.c )| 0 monsters | 0 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Mon Jul 10 05:47:58 EDT 2006


Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


visualization/nviz/src/togl_flythrough.c functions


flythrough_postdraw_cb (Begins at: 206 Ends at: 211)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

flythrough_postdraw_cb_set (Begins at: 213 Ends at: 222)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

flythrough_postdraw_cb_remove (Begins at: 224 Ends at: 233)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Nset_fly_mode_cmd (Begins at: 239 Ends at: 258)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Nset_fly_scale_cmd (Begins at: 260 Ends at: 267)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Nget_fly_scale_cmd (Begins at: 269 Ends at: 284)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

togl_flythrough_init (Begins at: 290 Ends at: 330)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

togl_flythrough_init_tcl (Begins at: 336 Ends at: 360)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

togl_flythrough_timer_cb (Begins at: 365 Ends at: 382)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

this_time (Begins at: 388 Ends at: 395)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

event_proc (Begins at: 397 Ends at: 428)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

calc_mxmy (Begins at: 430 Ends at: 447)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

mouse_valuator (Begins at: 450 Ends at: 531)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      82 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_navigation (Begins at: 535 Ends at: 657)
--------------+---------+-------+---------+
Complexity:   |      20 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      30 |       |      OK |
LOC:          |     123 |     * |         |
--------------+---------+-------+---------+
metrics are OK

surf_draw_all_together (Begins at: 662 Ends at: 698)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

vect_draw_all_together (Begins at: 700 Ends at: 717)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

site_draw_all_together (Begins at: 719 Ends at: 737)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

vol_draw_all_cmd (Begins at: 739 Ends at: 760)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Ndraw_all_together_cmd (Begins at: 762 Ends at: 850)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      53 |     * |         |
LOC:          |      89 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Nset_viewdir_cmd (Begins at: 856 Ends at: 868)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Nget_viewdir_cmd (Begins at: 871 Ends at: 893)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  Nget_viewdir_cmd

In visualization/nviz/src/togl_flythrough.c clones of  Nget_viewdir_cmd are:
	visualization/nviz/src/lights.c  getlgt_position


__________________________________________

Threshold GRASS6 key metrics values at 2006-07-10 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list