[GRASS-QA] GRASS QA: brad |
./grass6/visualization/nviz/src/map_obj.c |no clones | 0
monsters | 8 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Mon Jul 10 17:03:55 EDT 2006
Hello brad,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
visualization/nviz/src/map_obj.c functions
Nliteral_from_logical_cmd (Begins at: 85 Ends at: 188)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 32 | | OK |
LOC: | 104 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nlogical_from_literal_cmd (Begins at: 195 Ends at: 208)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_logical_name (Begins at: 215 Ends at: 268)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 54 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_logical_name (Begins at: 275 Ends at: 314)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_surf_list_cmd (Begins at: 321 Ends at: 339)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_vect_list_cmd (Begins at: 346 Ends at: 364)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_site_list_cmd (Begins at: 371 Ends at: 389)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_vol_list_cmd (Begins at: 396 Ends at: 429)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nnew_map_obj_cmd (Begins at: 431 Ends at: 671)
--------------+---------+-------+---------+
Complexity: | 32 | ** | Warning |
ParamNBR: | 4 | | OK |
CalledNBR: | 70 | ** | Warning |
LOC: | 241 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
Nmap_obj_cmd (Begins at: 673 Ends at: 737)
--------------+---------+-------+---------+
Complexity: | 28 | ** | Warning |
ParamNBR: | 4 | | OK |
CalledNBR: | 56 | ** | Warning |
LOC: | 65 | | OK |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
set_drawmode (Begins at: 745 Ends at: 802)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 13 | | OK |
LOC: | 58 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_drawmode (Begins at: 809 Ends at: 876)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 15 | | OK |
LOC: | 68 | | OK |
--------------+---------+-------+---------+
metrics are OK
draw_obj (Begins at: 884 Ends at: 908)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
delete_obj (Begins at: 915 Ends at: 939)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_res (Begins at: 947 Ends at: 999)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 11 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_res (Begins at: 1006 Ends at: 1048)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 16 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_wirecolor (Begins at: 1055 Ends at: 1082)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 5 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_wirecolor (Begins at: 1090 Ends at: 1118)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_trans (Begins at: 1125 Ends at: 1163)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 39 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_trans (Begins at: 1170 Ends at: 1198)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 8 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_nozero (Begins at: 1205 Ends at: 1241)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 7 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_nozero (Begins at: 1248 Ends at: 1289)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 9 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
metrics are OK
select_surf (Begins at: 1291 Ends at: 1325)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 6 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
metrics are OK
unselect_surf (Begins at: 1327 Ends at: 1355)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 6 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
surf_is_selected (Begins at: 1363 Ends at: 1395)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 8 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_exag_obj (Begins at: 1403 Ends at: 1426)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 4 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_exag_guess (Begins at: 1433 Ends at: 1459)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
load_obj (Begins at: 1461 Ends at: 1511)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 7 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_att (Begins at: 1513 Ends at: 1654)
--------------+---------+-------+---------+
Complexity: | 32 | ** | Warning |
ParamNBR: | 6 | * | |
CalledNBR: | 42 | * | |
LOC: | 142 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
set_att (Begins at: 1656 Ends at: 1870)
--------------+---------+-------+---------+
Complexity: | 26 | ** | Warning |
ParamNBR: | 6 | * | |
CalledNBR: | 55 | * | |
LOC: | 215 | ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
unset_att (Begins at: 1877 Ends at: 1890)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_mask_mode (Begins at: 1897 Ends at: 1911)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_mask_mode (Begins at: 1919 Ends at: 1947)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 4 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_idnum (Begins at: 1949 Ends at: 1962)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_type (Begins at: 1969 Ends at: 1981)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
att_atoi (Begins at: 1987 Ends at: 2003)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
sv_att_atoi (Begins at: 2009 Ends at: 2029)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_char_marker (Begins at: 2035 Ends at: 2072)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_int_marker (Begins at: 2078 Ends at: 2111)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
isosurf (Begins at: 2118 Ends at: 2163)
--------------+---------+-------+---------+
Complexity: | 18 | * | |
ParamNBR: | 5 | * | |
CalledNBR: | 34 | * | |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
slice (Begins at: 2170 Ends at: 2210)
--------------+---------+-------+---------+
Complexity: | 15 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 28 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2006-07-10 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list