[GRASS-QA] GRASS QA: markus | ./grass6/lib/db/dbmi_client/select.c |no clones | 0 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/db/dbmi_client/select.c functions


cmp (Begins at: 6 Ends at: 14)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cmpcat (Begins at: 16 Ends at: 24)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cmpcatkey (Begins at: 26 Ends at: 46)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_select_int (Begins at: 48 Ends at: 136)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      23 |       |      OK |
LOC:          |      89 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_select_value (Begins at: 138 Ends at: 190)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      11 |       |      OK |
LOC:          |      53 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_select_CatValArray (Begins at: 192 Ends at: 306)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      42 |     * |         |
LOC:          |     115 |     * |         |
--------------+---------+-------+---------+
metrics are OK

db_CatValArray_sort (Begins at: 310 Ends at: 313)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_CatValArray_get_value (Begins at: 319 Ends at: 329)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_CatValArray_get_value_int (Begins at: 335 Ends at: 345)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_CatValArray_get_value_double (Begins at: 351 Ends at: 363)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-07-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html