[GRASS-QA] GRASS QA: markus | ./grass6/lib/db/dbmi_client/copy_tab.c |no clones | 5 monsters | 2 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/db/dbmi_client/copy_tab.c functions


cmp (Begins at: 6 Ends at: 27)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db__copy_table (Begins at: 30 Ends at: 351)
--------------+---------+-------+---------+
Complexity:   |      46 |   *** | MONSTER |
ParamNBR:     |      11 |   *** | MONSTER |
CalledNBR:    |     142 |   *** | MONSTER |
LOC:          |     322 |   *** | MONSTER |
--------------+---------+-------+---------+
4 metric are OUT OF RANGE!

db_copy_table (Begins at: 354 Ends at: 368)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

db_copy_table_where (Begins at: 371 Ends at: 385)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

db_copy_table_select (Begins at: 388 Ends at: 406)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

db_copy_table_by_ints (Begins at: 409 Ends at: 417)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-07-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html