[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/opencell.c |no clones
| 0 monsters | 1 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Sat Jul 22 21:43:54 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/opencell.c functions
new_fileinfo (Begins at: 113 Ends at: 175)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 63 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_cell_old (Begins at: 179 Ends at: 234)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__open_cell_old (Begins at: 236 Ends at: 436)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 42 | * | |
LOC: | 201 | ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
G_open_cell_new (Begins at: 462 Ends at: 469)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_cell_new_random (Begins at: 471 Ends at: 478)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_cell_new_uncompressed (Begins at: 480 Ends at: 487)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_want_histogram (Begins at: 489 Ends at: 494)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_cell_format (Begins at: 497 Ends at: 510)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_cellvalue_format (Begins at: 512 Ends at: 520)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_fp_cell_new (Begins at: 522 Ends at: 545)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_fp_cell_new_uncompressed (Begins at: 548 Ends at: 569)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
clean_check_raster_name (Begins at: 572 Ends at: 604)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__open_raster_new (Begins at: 607 Ends at: 778)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 52 | * | |
LOC: | 172 | * | |
--------------+---------+-------+---------+
metrics are OK
allocate_compress_buf (Begins at: 786 Ends at: 801)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_work_buf (Begins at: 805 Ends at: 819)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_null_buf (Begins at: 825 Ends at: 839)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_mask_buf (Begins at: 844 Ends at: 858)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_temp_buf (Begins at: 863 Ends at: 890)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_fp_type (Begins at: 892 Ends at: 923)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_raster_map_is_fp (Begins at: 925 Ends at: 939)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_raster_map_type (Begins at: 941 Ends at: 960)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__check_fp_type (Begins at: 963 Ends at: 1018)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 21 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_raster_new (Begins at: 1020 Ends at: 1036)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_raster_new_uncompressed (Begins at: 1038 Ends at: 1068)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_quant_rules (Begins at: 1070 Ends at: 1097)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2006-07-22 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 80 |
LOC: 40 | 180 | 253 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list