[GRASS-QA] SOCCER LAB GRASS QA: 5 clones ( Dscreen.c list.c
get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c
position.c get_row.c pad.c main.c main.c command.c parser.c
GS2.c gethead.c anim_support.c draw.c position.c
site_attr_commands.c site_highlight_commands.c ) 0 monsters
and 1 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:54 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
visualization/nviz/src/site_highlight_commands.c functions
site_highlight_get_int_BBGGRR (Begins at: 207 Ends at: 216)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_highlight_init_tcl (Begins at: 236 Ends at: 250)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_highlight_get_geosite (Begins at: 254 Ends at: 269)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_highlight_get_geopoint (Begins at: 272 Ends at: 280)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_highlight_loop (Begins at: 283 Ends at: 324)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 8 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Nsite_highlight_cmd (Begins at: 329 Ends at: 372)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 44 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_highlight_list_cmd (Begins at: 375 Ends at: 430)
--------------+---------+-------+---------+
Complexity: | 21 | * | |
ParamNBR: | 4 | | OK |
CalledNBR: | 18 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_unhighlight_cmd (Begins at: 432 Ends at: 453)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_unhighlight_list_cmd (Begins at: 455 Ends at: 489)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_unhighlight_all_cmd (Begins at: 492 Ends at: 521)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_highlight_set_default_value_cmd (Begins at: 527 Ends at: 546)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_highlight_get_default_value_cmd (Begins at: 548 Ends at: 569)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_highlight_set_default_cmd (Begins at: 575 Ends at: 594)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_highlight_get_default_cmd (Begins at: 596 Ends at: 617)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
site_highlight_get_int_BBGGRR Nsite_highlight_get_default_cmd Nsite_highlight_get_default_value_cmd Nsite_highlight_set_default_cmd Nsite_highlight_set_default_value_cmd
In visualization/nviz/src/site_highlight_commands.c clones of site_highlight_get_int_BBGGRR are:
visualization/nviz/src/site_attr_commands.c attr_get_int_BBGGRR
In visualization/nviz/src/site_highlight_commands.c clones of Nsite_highlight_get_default_cmd are:
visualization/nviz/src/site_highlight_commands.c Nsite_highlight_get_default_value_cmd
In visualization/nviz/src/site_highlight_commands.c clones of Nsite_highlight_set_default_cmd are:
visualization/nviz/src/site_highlight_commands.c Nsite_highlight_set_default_value_cmd
In visualization/nviz/src/site_highlight_commands.c clones of Nsite_highlight_get_default_value_cmd are:
visualization/nviz/src/site_highlight_commands.c Nsite_highlight_get_default_cmd
In visualization/nviz/src/site_highlight_commands.c clones of Nsite_highlight_set_default_value_cmd are:
visualization/nviz/src/site_highlight_commands.c Nsite_highlight_set_default_cmd
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list