[GRASS-QA] SOCCER LAB GRASS QA: 4 clones ( Dscreen.c list.c
get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c
position.c get_row.c pad.c main.c main.c command.c parser.c
GS2.c gethead.c anim_support.c draw.c position.c
site_attr_commands.c ) 2 monsters and 6 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:54 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
visualization/nviz/src/site_attr_commands.c functions
site_attr_init_tcl (Begins at: 253 Ends at: 281)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_fields_name_cmd (Begins at: 312 Ends at: 338)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_fields_type_cmd (Begins at: 345 Ends at: 371)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_fields_name_and_type_cmd (Begins at: 378 Ends at: 419)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_field_values_cmd (Begins at: 421 Ends at: 469)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 49 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_field_not_emtpy_cats_cmd (Begins at: 471 Ends at: 520)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 50 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_record_values_cmd (Begins at: 522 Ends at: 578)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsite_attr_get_value_cmd (Begins at: 580 Ends at: 605)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_open_map (Begins at: 607 Ends at: 622)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 4 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
site_attr_close_map (Begins at: 625 Ends at: 629)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_init (Begins at: 641 Ends at: 648)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_set (Begins at: 651 Ends at: 704)
--------------+---------+-------+---------+
Complexity: | 18 | * | |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 19 | | OK |
LOC: | 54 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
site_attr_unset (Begins at: 706 Ends at: 720)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_get (Begins at: 722 Ends at: 730)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_set_color (Begins at: 734 Ends at: 767)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 19 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
site_attr_set_size (Begins at: 769 Ends at: 803)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 13 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
site_attr_set_fixed_color (Begins at: 805 Ends at: 810)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_set_fixed_size (Begins at: 812 Ends at: 817)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
site_attr_set_fixed_marker (Begins at: 819 Ends at: 838)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_get_int_BBGGRR (Begins at: 840 Ends at: 849)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_get_RRGGBB (Begins at: 852 Ends at: 870)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_get_char_RRGGBB (Begins at: 873 Ends at: 896)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_interpolated_values_cmd (Begins at: 898 Ends at: 983)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 30 | | OK |
LOC: | 86 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_interp_entries (Begins at: 985 Ends at: 1009)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 8 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
attr_interp_entries_string (Begins at: 1011 Ends at: 1017)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_interp_colors (Begins at: 1019 Ends at: 1058)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 12 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
attr_interp_colors_string (Begins at: 1060 Ends at: 1074)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 4 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_eval_entry (Begins at: 1078 Ends at: 1088)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_eval_entry_string (Begins at: 1090 Ends at: 1100)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
attr_eval_color (Begins at: 1102 Ends at: 1122)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 0 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
attr_eval_color_string (Begins at: 1124 Ends at: 1136)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 3 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Clone analysis:
This file has 4 potentially cloned functions:
attr_get_int_BBGGRR Nsite_attr_get_fields_type_cmd Nsite_attr_get_fields_name_cmd site_attr_get
In visualization/nviz/src/site_attr_commands.c clones of site_attr_get are:
ps/ps.map/do_header.c apply
In visualization/nviz/src/site_attr_commands.c clones of Nsite_attr_get_fields_name_cmd are:
visualization/nviz/src/site_attr_commands.c Nsite_attr_get_fields_type_cmd
In visualization/nviz/src/site_attr_commands.c clones of attr_get_int_BBGGRR are:
visualization/nviz/src/site_highlight_commands.c site_highlight_get_int_BBGGRR
In visualization/nviz/src/site_attr_commands.c clones of Nsite_attr_get_fields_type_cmd are:
visualization/nviz/src/site_attr_commands.c Nsite_attr_get_fields_name_cmd
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list