[GRASS-QA] SOCCER LAB GRASS QA: 3 clones ( Dscreen.c list.c
get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c
position.c get_row.c pad.c main.c main.c command.c parser.c
GS2.c gethead.c anim_support.c draw.c position.c ) 0 monsters
and 0 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:54 EDT 2006
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
visualization/nviz/src/position.c functions
Ninit_view_cmd (Begins at: 8 Ends at: 15)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_to_cmd (Begins at: 19 Ends at: 42)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_from_cmd (Begins at: 44 Ends at: 69)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nlook_here_cmd (Begins at: 71 Ends at: 81)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nhas_focus_cmd (Begins at: 83 Ends at: 97)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_focus_gui_cmd (Begins at: 100 Ends at: 139)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_focus_gui_cmd (Begins at: 143 Ends at: 184)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_real_position_cmd (Begins at: 187 Ends at: 228)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_focus_cmd (Begins at: 231 Ends at: 247)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_focus_real_cmd (Begins at: 250 Ends at: 266)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_focus_state_cmd (Begins at: 268 Ends at: 290)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_focus_top_cmd (Begins at: 292 Ends at: 335)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 44 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_focus_map_cmd (Begins at: 338 Ends at: 387)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 17 | | OK |
LOC: | 50 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nmove_to_real_cmd (Begins at: 390 Ends at: 407)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nmove_to_cmd (Begins at: 410 Ends at: 427)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_fov_cmd (Begins at: 430 Ends at: 444)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_fov_cmd (Begins at: 446 Ends at: 466)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_twist_cmd (Begins at: 468 Ends at: 483)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_twist_cmd (Begins at: 485 Ends at: 504)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_region_cmd (Begins at: 506 Ends at: 531)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_point_on_surf_cmd (Begins at: 533 Ends at: 575)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_point_on_surf_vect (Begins at: 577 Ends at: 625)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 49 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_dist_along_surf_cmd (Begins at: 627 Ends at: 654)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_cat_at_xy_cmd (Begins at: 660 Ends at: 693)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_val_at_xy_cmd (Begins at: 696 Ends at: 720)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_focus_cmd (Begins at: 722 Ends at: 748)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_longdim_cmd (Begins at: 751 Ends at: 764)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_zrange_cmd (Begins at: 766 Ends at: 796)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_xyrange_cmd (Begins at: 799 Ends at: 811)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_zextents_cmd (Begins at: 813 Ends at: 840)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nget_exag_cmd (Begins at: 842 Ends at: 856)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nset_exag_cmd (Begins at: 858 Ends at: 878)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nsave_3dview_cmd (Begins at: 880 Ends at: 925)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
Nload_3dview_cmd (Begins at: 927 Ends at: 962)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
Nset_fov_cmd Nmove_to_cmd Nmove_to_real_cmd
In visualization/nviz/src/position.c clones of Nset_fov_cmd are:
visualization/nviz/src/draw.c Ndraw_wire_cmd
In visualization/nviz/src/position.c clones of Nmove_to_cmd are:
visualization/nviz/src/position.c Nmove_to_real_cmd
In visualization/nviz/src/position.c clones of Nmove_to_real_cmd are:
visualization/nviz/src/position.c Nmove_to_cmd
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list