[GRASS-QA] SOCCER LAB GRASS QA: no clones 0 monsters and 3 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/Vlib/field.c functions


Vect_new_dblinks_struct (Begins at: 35 Ends at: 47)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_reset_dblinks (Begins at: 56 Ends at: 66)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_map_add_dblink (Begins at: 69 Ends at: 96)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Vect_map_del_dblink (Begins at: 105 Ends at: 140)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_map_check_dblink (Begins at: 149 Ends at: 152)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_check_dblink (Begins at: 161 Ends at: 181)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_add_dblink (Begins at: 184 Ends at: 220)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       9 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Vect_default_field_info (Begins at: 229 Ends at: 303)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      27 |       |      OK |
LOC:          |      75 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_get_dblink (Begins at: 306 Ends at: 338)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      33 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_get_field (Begins at: 341 Ends at: 356)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_read_dblinks (Begins at: 365 Ends at: 549)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      51 |     * |         |
LOC:          |     185 |    ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Vect_write_dblinks (Begins at: 558 Ends at: 594)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_subst_var (Begins at: 603 Ends at: 642)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_set_db_updated (Begins at: 650 Ends at: 657)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html