[GRASS-QA] SOCCER LAB GRASS QA: 1 clones ( main.c writeVTKData.c ) 0 monsters and 3 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster3d/r3.out.vtk/writeVTKData.c functions


GetRasterValueAsDouble (Begins at: 38 Ends at: 68)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

GetG3DRasterValueAsDouble (Begins at: 73 Ends at: 96)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

writeVTKPoints (Begins at: 101 Ends at: 240)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      46 |     * |         |
LOC:          |     140 |     * |         |
--------------+---------+-------+---------+
metrics are OK

writeVTKUnstructuredGridCells (Begins at: 245 Ends at: 307)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      63 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKData (Begins at: 313 Ends at: 375)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      15 |       |      OK |
LOC:          |      63 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKRGBVoxelData (Begins at: 381 Ends at: 475)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      20 |       |      OK |
LOC:          |      95 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

writeVTKVectorData (Begins at: 481 Ends at: 557)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      14 |       |      OK |
LOC:          |      77 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  GetRasterValueAsDouble

In raster3d/r3.out.vtk/writeVTKData.c clones of  GetRasterValueAsDouble are:
	raster/r.out.vtk/writeascii.c  GetRasterValueAsDouble


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-16 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html