[GRASS-QA] SOCCER LAB GRASS QA: 3 clones ( ask.c graphics.c ) 0 monsters and 1 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.vpoints/graphics.c functions


makeview (Begins at: 7 Ends at: 42)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Init_graphics (Begins at: 45 Ends at: 76)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Outline_box (Begins at: 79 Ends at: 88)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Text_width (Begins at: 92 Ends at: 102)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Text (Begins at: 105 Ends at: 113)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Uparrow (Begins at: 116 Ends at: 125)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Downarrow (Begins at: 128 Ends at: 137)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  Text  makeview  Init_graphics

In imagery/i.vpoints/graphics.c clones of  makeview are:
	imagery/i.points/graphics.c  makeview
	imagery/i.ortho.photo/photo.2target/graphics.c  makeview
	imagery/i.ortho.photo/photo.2image/graphics.c  makeview
	imagery/i.class/graphics.c  makeview

In imagery/i.vpoints/graphics.c clones of  Init_graphics are:
	imagery/i.points/graphics.c  Init_graphics

In imagery/i.vpoints/graphics.c clones of  Text are:
	imagery/i.points/graphics.c  Text
	imagery/i.ortho.photo/photo.2target/graphics.c  Text
	imagery/i.ortho.photo/photo.2image/graphics.c  Text
	imagery/i.class/graphics.c  Text


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-17 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html