[GRASS-QA] SOCCER LAB GRASS QA: no clones 1 monsters and 4 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Tue Jun 20 06:12:26 EDT 2006


Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.surf.idw/main.c functions


main (Begins at: 28 Ends at: 152)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      49 |     * |         |
LOC:          |     125 |     * |         |
--------------+---------+-------+---------+
metrics are OK

lookup_and_function_ptrs (Begins at: 154 Ends at: 187)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

interpolate (Begins at: 190 Ends at: 278)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      89 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

make_neighbors_list (Begins at: 280 Ends at: 343)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      10 |       |      OK |
LOC:          |      64 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

search (Begins at: 348 Ends at: 394)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       8 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

exhaust (Begins at: 397 Ends at: 423)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

offset_distance (Begins at: 425 Ends at: 428)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

completed_row (Begins at: 434 Ends at: 437)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

next_row (Begins at: 440 Ends at: 455)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

first_west (Begins at: 463 Ends at: 477)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_neighbors (Begins at: 485 Ends at: 513)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       3 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

exhaust_search (Begins at: 520 Ends at: 542)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

triangulate (Begins at: 549 Ends at: 557)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_neighbor (Begins at: 560 Ends at: 575)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

replace_neighbor (Begins at: 578 Ends at: 600)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sort_neighbors (Begins at: 603 Ends at: 616)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

free_row_lists (Begins at: 620 Ends at: 637)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

row_lists (Begins at: 640 Ends at: 700)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       8 |       |      OK |
LOC:          |      61 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

lookup_tables (Begins at: 707 Ends at: 725)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-06-20 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list