[GRASS-QA] GRASS QA: hamish | ./grass6/imagery/i.vpoints/input.c |5
clones ( analyze.c drawcell.c driver.c input.c )| 0 monsters
| 0 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Fri Jun 23 04:11:41 EDT 2006
Hello hamish,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
imagery/i.vpoints/input.c functions
Input_pointer (Begins at: 19 Ends at: 22)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Input_box (Begins at: 24 Ends at: 27)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Input_other (Begins at: 29 Ends at: 45)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
mouse (Begins at: 47 Ends at: 103)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
use_mouse_msg (Begins at: 106 Ends at: 111)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
draw_objects (Begins at: 113 Ends at: 177)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 16 | | OK |
LOC: | 65 | | OK |
--------------+---------+-------+---------+
metrics are OK
find (Begins at: 179 Ends at: 201)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
select_option (Begins at: 203 Ends at: 215)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
draw_option_boxes (Begins at: 217 Ends at: 235)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
visible (Begins at: 237 Ends at: 242)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Menu_msg (Begins at: 244 Ends at: 264)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Start_mouse_in_menu (Begins at: 266 Ends at: 273)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
Menu_msg draw_objects find select_option draw_option_boxes
In imagery/i.vpoints/input.c clones of select_option are:
imagery/i.points/input.c select_option
imagery/i.ortho.photo/photo.2target/input.c select_option
imagery/i.ortho.photo/photo.2image/input.c select_option
imagery/i.class/input.c select_option
In imagery/i.vpoints/input.c clones of Menu_msg are:
imagery/i.points/input.c Menu_msg
imagery/i.ortho.photo/photo.2target/input.c Menu_msg
imagery/i.ortho.photo/photo.2image/input.c Menu_msg
imagery/i.class/input.c Menu_msg
In imagery/i.vpoints/input.c clones of draw_option_boxes are:
imagery/i.points/input.c draw_option_boxes
imagery/i.ortho.photo/photo.2target/input.c draw_option_boxes
imagery/i.ortho.photo/photo.2image/input.c draw_option_boxes
imagery/i.class/input.c draw_option_boxes
In imagery/i.vpoints/input.c clones of find are:
imagery/i.points/input.c find
imagery/i.ortho.photo/photo.2target/input.c find
imagery/i.ortho.photo/photo.2image/input.c find
imagery/i.class/input.c find
In imagery/i.vpoints/input.c clones of draw_objects are:
imagery/i.points/input.c draw_objects
imagery/i.ortho.photo/photo.2target/input.c draw_objects
imagery/i.ortho.photo/photo.2image/input.c draw_objects
imagery/i.class/input.c draw_objects
__________________________________________
Threshold GRASS6 key metrics values at 2006-06-23 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 180 | 252 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list