[GRASS-QA] GRASS QA: cho | ./grass6/vector/v.digit/i_face.c |3 clones ( edit.c init.c i_face.c )| 0 monsters | 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello cho,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.digit/i_face.c functions


i_prompt (Begins at: 18 Ends at: 22)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_prompt_buttons (Begins at: 26 Ends at: 32)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_coor (Begins at: 36 Ends at: 47)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_set_color (Begins at: 50 Ends at: 64)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_set_on (Begins at: 67 Ends at: 78)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_update (Begins at: 81 Ends at: 85)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_new_line_options (Begins at: 88 Ends at: 117)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_set_cat_mode (Begins at: 120 Ends at: 135)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_var_seti (Begins at: 138 Ends at: 148)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_var_setd (Begins at: 151 Ends at: 161)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_var_setc (Begins at: 164 Ends at: 177)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_message (Begins at: 180 Ends at: 216)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

i_add_bgcmd (Begins at: 219 Ends at: 252)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  i_set_on  i_var_setd  i_var_seti

In vector/v.digit/i_face.c clones of  i_var_seti are:
	vector/v.digit/i_face.c  i_var_setd

In vector/v.digit/i_face.c clones of  i_var_setd are:
	vector/v.digit/i_face.c  i_var_seti

In vector/v.digit/i_face.c clones of  i_set_on are:
	vector/v.in.dxf/write_polylines.c  write_polylines


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-28 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html