[GRASS-QA] SOCCER LAB GRASS QA: 4 clones ( gs_bm.c ) 0 monsters and 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/ogsf/gs_bm.c functions


gsbm_make_mask (Begins at: 16 Ends at: 52)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsbm_zero_mask (Begins at: 54 Ends at: 74)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsbm_masks (Begins at: 76 Ends at: 118)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsbm_or_masks (Begins at: 121 Ends at: 124)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsbm_ornot_masks (Begins at: 127 Ends at: 130)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsbm_and_masks (Begins at: 133 Ends at: 136)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsbm_xor_masks (Begins at: 139 Ends at: 142)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gs_update_curmask (Begins at: 145 Ends at: 267)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      29 |       |      OK |
LOC:          |     123 |     * |         |
--------------+---------+-------+---------+
metrics are OK

print_bm (Begins at: 270 Ends at: 283)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  gsbm_xor_masks  gsbm_and_masks  gsbm_ornot_masks  gsbm_or_masks

In lib/ogsf/gs_bm.c clones of  gsbm_xor_masks are:
	lib/ogsf/gs_bm.c  gsbm_and_masks

In lib/ogsf/gs_bm.c clones of  gsbm_or_masks are:
	lib/ogsf/gs_bm.c  gsbm_ornot_masks

In lib/ogsf/gs_bm.c clones of  gsbm_ornot_masks are:
	lib/ogsf/gs_bm.c  gsbm_or_masks

In lib/ogsf/gs_bm.c clones of  gsbm_and_masks are:
	lib/ogsf/gs_bm.c  gsbm_xor_masks


__________________________________________

Threshold GRASS6 key metrics values at 2006-05-02 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     256 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html