[GRASS-QA] SOCCER LAB GRASS QA: no clones 1 monsters and 1 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello radim,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/form/form.c functions


close_form (Begins at: 37 Ends at: 42)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

reset_values (Begins at: 46 Ends at: 55)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_value (Begins at: 58 Ends at: 81)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

submit (Begins at: 85 Ends at: 250)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      90 |   *** | MONSTER |
LOC:          |     166 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

main (Begins at: 256 Ends at: 389)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      72 |    ** | Warning |
LOC:          |     134 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-05-02 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     256 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html