[GRASS-QA] SOCCER LAB GRASS QA: no clones 0 monsters and 2 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Fri May 5 19:38:31 EDT 2006


Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/ogsf/gsd_objs.c functions


init_stuff (Begins at: 92 Ends at: 129)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_plus (Begins at: 131 Ends at: 157)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_line_onsurf (Begins at: 160 Ends at: 186)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_nline_onsurf (Begins at: 193 Ends at: 224)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_x (Begins at: 227 Ends at: 267)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_diamond (Begins at: 269 Ends at: 360)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      47 |     * |         |
LOC:          |      92 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_cube (Begins at: 362 Ends at: 428)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      43 |     * |         |
LOC:          |      67 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_draw_box (Begins at: 430 Ends at: 480)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      35 |     * |         |
LOC:          |      51 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_drawsphere (Begins at: 481 Ends at: 488)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_diamond_lines (Begins at: 490 Ends at: 508)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_draw_asterisk (Begins at: 510 Ends at: 556)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      30 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_draw_gyro (Begins at: 558 Ends at: 603)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |      46 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_3dcursor (Begins at: 605 Ends at: 639)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dir_to_slope_aspect (Begins at: 641 Ends at: 697)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_north_arrow (Begins at: 703 Ends at: 781)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      32 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_arrow (Begins at: 783 Ends at: 842)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      22 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

gsd_arrow_onsurf (Begins at: 845 Ends at: 928)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      84 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_3darrow (Begins at: 933 Ends at: 1003)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      27 |       |      OK |
LOC:          |      71 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

primitive_cone (Begins at: 1007 Ends at: 1034)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

primitive_cylinder (Begins at: 1038 Ends at: 1106)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      45 |     * |         |
LOC:          |      69 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

gsd_box (Begins at: 1114 Ends at: 1175)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      43 |     * |         |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-05-05 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       182 |     256 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html



More information about the grass-qa mailing list