[GRASS-QA] SOCCER LAB GRASS QA: 1 clones ( main.c ) 0 monsters and
3 warnings
cvs at proxy.soccerlab.polymtl.ca
cvs at proxy.soccerlab.polymtl.ca
Sun May 21 17:46:28 EDT 2006
Hello soeren,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster3d/r3.out.vtk/main.c functions
fatalError (Begins at: 64 Ends at: 81)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
setParams (Begins at: 87 Ends at: 194)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 26 | | OK |
LOC: | 108 | | OK |
--------------+---------+-------+---------+
metrics are OK
OpenInputMap (Begins at: 200 Ends at: 215)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
CloseInputMap (Begins at: 221 Ends at: 227)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
CheckInputMaps (Begins at: 233 Ends at: 308)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 23 | | OK |
LOC: | 76 | | OK |
--------------+---------+-------+---------+
metrics are OK
OpenWriteRGBMaps (Begins at: 314 Ends at: 383)
--------------+---------+-------+---------+
Complexity: | 16 | * | |
ParamNBR: | 3 | | OK |
CalledNBR: | 18 | | OK |
LOC: | 70 | | OK |
--------------+---------+-------+---------+
metrics are OK
OpenWriteVectorMaps (Begins at: 388 Ends at: 458)
--------------+---------+-------+---------+
Complexity: | 16 | * | |
ParamNBR: | 3 | | OK |
CalledNBR: | 18 | | OK |
LOC: | 71 | | OK |
--------------+---------+-------+---------+
metrics are OK
writeVTKStructuredPointHeader (Begins at: 464 Ends at: 518)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 16 | | OK |
LOC: | 55 | | OK |
--------------+---------+-------+---------+
metrics are OK
writeVTKStructuredGridHeader (Begins at: 524 Ends at: 539)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
writeVTKUnstructuredGridHeader (Begins at: 544 Ends at: 557)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
writeVTKPoints (Begins at: 563 Ends at: 732)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 4 | | OK |
CalledNBR: | 50 | * | |
LOC: | 170 | * | |
--------------+---------+-------+---------+
metrics are OK
writeVTKUnstructuredGridCells (Begins at: 737 Ends at: 799)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 63 | | OK |
--------------+---------+-------+---------+
metrics are OK
writeVTKData (Begins at: 805 Ends at: 879)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 25 | | OK |
LOC: | 75 | | OK |
--------------+---------+-------+---------+
metrics are OK
writeVTKRGBVoxelData (Begins at: 885 Ends at: 1024)
--------------+---------+-------+---------+
Complexity: | 18 | * | |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 36 | * | |
LOC: | 140 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
writeVTKVectorData (Begins at: 1030 Ends at: 1133)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 24 | | OK |
LOC: | 104 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
main (Begins at: 1138 Ends at: 1305)
--------------+---------+-------+---------+
Complexity: | 21 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 58 | ** | Warning |
LOC: | 168 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Clone analysis:
This file has 1 potentially cloned functions:
OpenInputMap
In raster3d/r3.out.vtk/main.c clones of OpenInputMap are:
raster/r.to.rast3/main.c OpenInputMap
__________________________________________
Threshold GRASS6 key metrics values at 2006-05-21 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 36 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 79 |
LOC: 40 | 182 | 253 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list