[GRASS-QA] GRASS QA: hamish | ./grass6/vector/v.buffer/main.c |1 clones ( parser.c parser.c main.c )| 3 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.buffer/main.c functions


input_distance (Begins at: 35 Ends at: 121)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      16 |       |      OK |
LOC:          |      87 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

area_in_buffer (Begins at: 128 Ends at: 207)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      15 |       |      OK |
LOC:          |      80 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

stop (Begins at: 209 Ends at: 217)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 220 Ends at: 716)
--------------+---------+-------+---------+
Complexity:   |      56 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     184 |   *** | MONSTER |
LOC:          |     497 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

Clone analysis:

This file has 1 potentially cloned functions:
  stop

In vector/v.buffer/main.c clones of  stop are:
	raster/r.carve/vect.c  open_new_vect


__________________________________________

Threshold GRASS6 key metrics values at 2006-11-17 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html