[GRASS-QA] GRASS QA: glynn | ./grass6/general/g.region/cmd/main.c |1 clones ( main.c )| 3 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Mon Oct 2 23:27:53 EDT 2006



Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


general/g.region/cmd/main.c functions


main (Begins at: 28 Ends at: 767)
--------------+---------+-------+---------+
Complexity:   |     104 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     227 |   *** | MONSTER |
LOC:          |     740 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

die (Begins at: 769 Ends at: 775)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

nsew (Begins at: 777 Ends at: 783)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

llinfo (Begins at: 785 Ends at: 793)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  nsew

In general/g.region/cmd/main.c clones of  nsew are:
	raster/r.region/main.c  nsew


__________________________________________

Threshold GRASS6 key metrics values at 2006-10-02 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      81 |
LOC:                    40 |       182 |     253 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list