[GRASS-QA] GRASS QA: moritz | ./grass6/lib/db/sqlp/sql.c |1 clones
( parser.c main.c main.c main.c main.c sql.c )| 0 monsters |
0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Oct 11 05:38:42 EDT 2006
Hello moritz,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/db/sqlp/sql.c functions
sqpSaveStr (Begins at: 31 Ends at: 41)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpInitValue (Begins at: 44 Ends at: 50)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpCopyValue (Begins at: 53 Ends at: 65)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpInitParser (Begins at: 67 Ends at: 80)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpCommand (Begins at: 82 Ends at: 86)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpTable (Begins at: 88 Ends at: 92)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpColumn (Begins at: 94 Ends at: 104)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpColumnDef (Begins at: 106 Ends at: 119)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpValue (Begins at: 121 Ends at: 153)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpAssignment (Begins at: 155 Ends at: 191)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 4 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpOrderColumn (Begins at: 193 Ends at: 199)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpNewNode (Begins at: 202 Ends at: 208)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpNewExpressionNode (Begins at: 211 Ends at: 223)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpNewColumnNode (Begins at: 226 Ends at: 236)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpNewValueNode (Begins at: 239 Ends at: 254)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpFreeNode (Begins at: 257 Ends at: 274)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpOperatorCode (Begins at: 277 Ends at: 321)
--------------+---------+-------+---------+
Complexity: | 16 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 17 | | OK |
LOC: | 45 | | OK |
--------------+---------+-------+---------+
metrics are OK
sqpOperatorName (Begins at: 324 Ends at: 371)
--------------+---------+-------+---------+
Complexity: | 16 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 48 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
sqpSaveStr
In lib/db/sqlp/sql.c clones of sqpSaveStr are:
db/drivers/dbf/str.c save_string
__________________________________________
Threshold GRASS6 key metrics values at 2006-10-11 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 85 |
LOC: 41 | 189 | 264 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list