[GRASS-QA] GRASS QA: hamish | ./grass6/vector/v.in.ascii/points.c |no clones | 2 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.in.ascii/points.c functions


is_int (Begins at: 12 Ends at: 22)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

is_double (Begins at: 26 Ends at: 51)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

points_analyse (Begins at: 53 Ends at: 207)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |      11 |   *** | MONSTER |
CalledNBR:    |      39 |     * |         |
LOC:          |     155 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

points_to_bin (Begins at: 209 Ends at: 332)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |      13 |   *** | MONSTER |
CalledNBR:    |      51 |     * |         |
LOC:          |     124 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-10-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     264 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html