[GRASS-QA] GRASS QA: hamish | ./grass6/raster/r.le/r.le.trace/main.c |no clones | 3 monsters | 5 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.le/r.le.trace/main.c functions


main (Begins at: 40 Ends at: 112)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      32 |       |      OK |
LOC:          |      73 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_map (Begins at: 114 Ends at: 154)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       9 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

show_patch (Begins at: 156 Ends at: 274)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      48 |     * |         |
LOC:          |     119 |     * |         |
--------------+---------+-------+---------+
metrics are OK

patch_attr (Begins at: 279 Ends at: 324)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      46 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_patch (Begins at: 326 Ends at: 353)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scr_cell (Begins at: 355 Ends at: 368)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cell_clip_drv (Begins at: 370 Ends at: 489)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      12 |       |      OK |
LOC:          |     120 |     * |         |
--------------+---------+-------+---------+
metrics are OK

cell_clip (Begins at: 496 Ends at: 717)
--------------+---------+-------+---------+
Complexity:   |      32 |    ** | Warning |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      37 |     * |         |
LOC:          |     222 |    ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code

trace (Begins at: 725 Ends at: 842)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |     118 |     * |         |
--------------+---------+-------+---------+
metrics are OK

get_bd (Begins at: 844 Ends at: 1503)
--------------+---------+-------+---------+
Complexity:   |      70 |   *** | MONSTER |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |      31 |       |      OK |
LOC:          |     660 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

yes_nb (Begins at: 1505 Ends at: 1636)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       2 |       |      OK |
LOC:          |     132 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

clockwise (Begins at: 1638 Ends at: 1646)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-10-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html