[GRASS-QA] GRASS QA: brad | ./grass6/raster/r.resamp.stats/main.c |1 clones ( main.c )| 0 monsters | 2 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Thu Sep 28 05:28:14 EDT 2006



Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.resamp.stats/main.c functions


build_method_list (Begins at: 26 Ends at: 43)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_method (Begins at: 45 Ends at: 54)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 56 Ends at: 237)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      68 |    ** | Warning |
LOC:          |     182 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  build_method_list

In raster/r.resamp.stats/main.c clones of  build_method_list are:
	raster/r.series/main.c  build_method_list


__________________________________________

Threshold GRASS6 key metrics values at 2006-09-28 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list