[GRASS-QA] GRASS QA: glynn | ./grass6/lib/display/draw2.c |2 clones
( main.c draw2.c )| 0 monsters | 1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 7 20:34:52 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/display/draw2.c functions
alloc_int (Begins at: 78 Ends at: 87)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
alloc_float (Begins at: 89 Ends at: 98)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
dealloc_float (Begins at: 100 Ends at: 115)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_convert (Begins at: 117 Ends at: 128)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
dist_plane (Begins at: 130 Ends at: 133)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
interpolate (Begins at: 135 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
clip_plane (Begins at: 140 Ends at: 172)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_clip (Begins at: 174 Ends at: 197)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
shift_count (Begins at: 199 Ends at: 202)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
shift_angle (Begins at: 204 Ends at: 207)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
coerce (Begins at: 209 Ends at: 215)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
euclidify (Begins at: 217 Ends at: 247)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_ll_wrap (Begins at: 249 Ends at: 280)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 5 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
D_set_clip (Begins at: 282 Ends at: 304)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_clip_to_map (Begins at: 306 Ends at: 323)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_move_clip (Begins at: 325 Ends at: 344)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
line_clip (Begins at: 346 Ends at: 371)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
line_clip_ll (Begins at: 373 Ends at: 395)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_cont_clip (Begins at: 397 Ends at: 413)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polydots_clip (Begins at: 415 Ends at: 446)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
cull_polyline_plane (Begins at: 448 Ends at: 493)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
polyline_cull (Begins at: 495 Ends at: 522)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polyline_cull (Begins at: 524 Ends at: 536)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
polyline_clip (Begins at: 538 Ends at: 544)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polyline_clip (Begins at: 546 Ends at: 558)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
cull_polygon_plane (Begins at: 560 Ends at: 605)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
polygon_cull (Begins at: 607 Ends at: 634)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polygon_cull (Begins at: 636 Ends at: 645)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
clip_polygon_plane (Begins at: 647 Ends at: 687)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
polygon_clip (Begins at: 689 Ends at: 716)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polygon_clip (Begins at: 718 Ends at: 727)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
box_clip (Begins at: 729 Ends at: 745)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
box_clip_ll (Begins at: 747 Ends at: 760)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_box_clip (Begins at: 762 Ends at: 771)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_move (Begins at: 773 Ends at: 779)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_cont (Begins at: 781 Ends at: 787)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polydots (Begins at: 789 Ends at: 793)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polyline (Begins at: 795 Ends at: 799)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_polygon (Begins at: 801 Ends at: 805)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
D_box (Begins at: 807 Ends at: 819)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
D_cont D_move
In lib/display/draw2.c clones of D_move are:
lib/display/draw2.c D_cont
In lib/display/draw2.c clones of D_cont are:
lib/display/draw2.c D_move
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-07 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list