[GRASS-QA] GRASS QA: glynn | ./grass6/lib/display/window.c |no clones | 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/display/window.c functions


D_new_window (Begins at: 60 Ends at: 118)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      12 |       |      OK |
LOC:          |      59 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_new_window_percent (Begins at: 120 Ends at: 150)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_set_cur_wind (Begins at: 152 Ends at: 225)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      74 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_get_cur_wind (Begins at: 227 Ends at: 260)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_show_window (Begins at: 262 Ends at: 297)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_get_screen_window (Begins at: 299 Ends at: 328)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_check_map_window (Begins at: 330 Ends at: 390)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      61 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_reset_screen_window (Begins at: 392 Ends at: 419)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_timestamp (Begins at: 421 Ends at: 461)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_remove_window (Begins at: 463 Ends at: 477)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_erase_window (Begins at: 479 Ends at: 486)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_erase (Begins at: 488 Ends at: 505)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_remove_windows (Begins at: 507 Ends at: 524)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_full_screen (Begins at: 526 Ends at: 536)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-07 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html