[GRASS-QA] GRASS QA: soeren | ./grass6/lib/gpde/N_gradient.c |13
clones ( N_arrays.c N_gradient.c )| 1 monsters | 1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Mon Apr 9 19:48:52 EDT 2007
Hello soeren,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gpde/N_gradient.c functions
N_alloc_gradient_2d (Begins at: 27 Ends at: 34)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_2d (Begins at: 42 Ends at: 58)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_2d (Begins at: 60 Ends at: 82)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_2d (Begins at: 84 Ends at: 112)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_get_gradient_2d (Begins at: 114 Ends at: 142)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_3d (Begins at: 150 Ends at: 157)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_3d (Begins at: 165 Ends at: 184)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_3d (Begins at: 186 Ends at: 211)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 2 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_3d (Begins at: 213 Ends at: 245)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_get_gradient_3d (Begins at: 247 Ends at: 287)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 8 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_neighbours_x (Begins at: 289 Ends at: 298)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_neighbours_x (Begins at: 306 Ends at: 326)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_neighbours_x (Begins at: 328 Ends at: 355)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_neighbours_x (Begins at: 358 Ends at: 382)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_neighbours_y (Begins at: 384 Ends at: 393)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_neighbours_y (Begins at: 401 Ends at: 420)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_neighbours_y (Begins at: 422 Ends at: 449)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_neighbours_y (Begins at: 452 Ends at: 476)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_neighbours_z (Begins at: 478 Ends at: 487)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_neighbours_z (Begins at: 495 Ends at: 517)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_neighbours_z (Begins at: 519 Ends at: 551)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 2 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
N_copy_gradient_neighbours_z (Begins at: 554 Ends at: 582)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_neighbours_2d (Begins at: 584 Ends at: 596)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_neighbours_2d (Begins at: 604 Ends at: 623)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_neighbours_2d (Begins at: 626 Ends at: 656)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_neighbours_2d (Begins at: 659 Ends at: 695)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_get_gradient_neighbours_2d (Begins at: 697 Ends at: 762)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 22 | | OK |
LOC: | 66 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_neighbours_3d (Begins at: 764 Ends at: 782)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_neighbours_3d (Begins at: 790 Ends at: 816)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_gradient_neighbours_3d (Begins at: 819 Ends at: 866)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 8 | ** | Warning |
CalledNBR: | 10 | | OK |
LOC: | 48 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
N_copy_gradient_neighbours_3d (Begins at: 869 Ends at: 911)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_field_2d (Begins at: 913 Ends at: 929)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_field_2d (Begins at: 937 Ends at: 956)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_field_2d (Begins at: 959 Ends at: 971)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_print_gradient_field_2d_info (Begins at: 979 Ends at: 1009)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 14 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_alloc_gradient_field_3d (Begins at: 1011 Ends at: 1036)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_free_gradient_field_3d (Begins at: 1038 Ends at: 1059)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_copy_gradient_field_3d (Begins at: 1062 Ends at: 1075)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_print_gradient_field_3d_info (Begins at: 1083 Ends at: 1106)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 18 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 13 potentially cloned functions:
N_alloc_gradient_3d N_alloc_gradient_2d N_alloc_gradient_neighbours_z N_alloc_gradient_neighbours_y N_alloc_gradient_neighbours_x N_copy_gradient_neighbours_y N_copy_gradient_neighbours_x N_copy_gradient_neighbours_z N_copy_gradient_2d N_create_gradient_neighbours_y N_create_gradient_neighbours_x N_free_gradient_field_2d N_free_gradient_neighbours_2d
In lib/gpde/N_gradient.c clones of N_copy_gradient_neighbours_x are:
lib/gpde/N_gradient.c N_copy_gradient_neighbours_y
In lib/gpde/N_gradient.c clones of N_copy_gradient_neighbours_y are:
lib/gpde/N_gradient.c N_copy_gradient_neighbours_x
In lib/gpde/N_gradient.c clones of N_create_gradient_neighbours_x are:
lib/gpde/N_gradient.c N_create_gradient_neighbours_y
In lib/gpde/N_gradient.c clones of N_free_gradient_field_2d are:
lib/gpde/N_gradient.c N_free_gradient_neighbours_2d
In lib/gpde/N_gradient.c clones of N_alloc_gradient_3d are:
lib/gpde/N_gradient.c N_alloc_gradient_2d
In lib/gpde/N_gradient.c clones of N_create_gradient_neighbours_y are:
lib/gpde/N_gradient.c N_create_gradient_neighbours_x
In lib/gpde/N_gradient.c clones of N_alloc_gradient_neighbours_x are:
lib/gpde/N_gradient.c N_alloc_gradient_neighbours_z
lib/gpde/N_gradient.c N_alloc_gradient_neighbours_y
In lib/gpde/N_gradient.c clones of N_copy_gradient_2d are:
lib/gpde/N_gradient.c N_copy_gradient_neighbours_z
In lib/gpde/N_gradient.c clones of N_alloc_gradient_2d are:
lib/gpde/N_gradient.c N_alloc_gradient_3d
In lib/gpde/N_gradient.c clones of N_alloc_gradient_neighbours_z are:
lib/gpde/N_gradient.c N_alloc_gradient_neighbours_y
lib/gpde/N_gradient.c N_alloc_gradient_neighbours_x
In lib/gpde/N_gradient.c clones of N_free_gradient_neighbours_2d are:
lib/gpde/N_gradient.c N_free_gradient_field_2d
In lib/gpde/N_gradient.c clones of N_copy_gradient_neighbours_z are:
lib/gpde/N_gradient.c N_copy_gradient_2d
In lib/gpde/N_gradient.c clones of N_alloc_gradient_neighbours_y are:
lib/gpde/N_gradient.c N_alloc_gradient_neighbours_z
lib/gpde/N_gradient.c N_alloc_gradient_neighbours_x
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-09 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list