[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/opencell.c |2 clones
( cats.c color_read.c find_cell.c find_vect.c fpreclass.c
get_row.c key_value1.c null_val.c opencell.c )| 0 monsters |
1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 14 19:38:27 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/opencell.c functions
new_fileinfo (Begins at: 113 Ends at: 173)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 61 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_cell_old (Begins at: 177 Ends at: 232)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__open_cell_old (Begins at: 234 Ends at: 434)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 42 | * | |
LOC: | 201 | ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
G_open_cell_new (Begins at: 460 Ends at: 467)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_cell_new_random (Begins at: 469 Ends at: 476)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_cell_new_uncompressed (Begins at: 478 Ends at: 485)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_want_histogram (Begins at: 487 Ends at: 492)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_cell_format (Begins at: 495 Ends at: 508)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_cellvalue_format (Begins at: 510 Ends at: 518)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_fp_cell_new (Begins at: 520 Ends at: 543)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_fp_cell_new_uncompressed (Begins at: 546 Ends at: 567)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
clean_check_raster_name (Begins at: 570 Ends at: 602)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__open_raster_new (Begins at: 605 Ends at: 776)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 52 | * | |
LOC: | 172 | * | |
--------------+---------+-------+---------+
metrics are OK
allocate_compress_buf (Begins at: 784 Ends at: 799)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_work_buf (Begins at: 803 Ends at: 817)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_null_buf (Begins at: 823 Ends at: 837)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_mask_buf (Begins at: 842 Ends at: 856)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__reallocate_temp_buf (Begins at: 861 Ends at: 888)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_fp_type (Begins at: 890 Ends at: 919)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_raster_map_is_fp (Begins at: 921 Ends at: 953)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_raster_map_type (Begins at: 955 Ends at: 974)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_raster_map_type2 (Begins at: 976 Ends at: 1006)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_raster_map_type (Begins at: 1008 Ends at: 1012)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__check_fp_type (Begins at: 1016 Ends at: 1071)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 21 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_raster_new (Begins at: 1073 Ends at: 1089)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_open_raster_new_uncompressed (Begins at: 1091 Ends at: 1120)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_quant_rules (Begins at: 1122 Ends at: 1149)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
G_raster_map_type2 G_raster_map_type
In lib/gis/opencell.c clones of G_raster_map_type2 are:
lib/gis/opencell.c G_raster_map_type
In lib/gis/opencell.c clones of G_raster_map_type are:
lib/gis/opencell.c G_raster_map_type2
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list