[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/plot.c |no clones | 1
monsters | 1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 14 19:38:27 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/plot.c functions
G_setup_plot (Begins at: 97 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 5 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
G_setup_fill (Begins at: 140 Ends at: 169)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_where_xy (Begins at: 171 Ends at: 192)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_where_en (Begins at: 194 Ends at: 201)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_point (Begins at: 203 Ends at: 234)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_line (Begins at: 236 Ends at: 240)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_line2 (Begins at: 242 Ends at: 246)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
fastline (Begins at: 252 Ends at: 258)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
slowline (Begins at: 266 Ends at: 332)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 18 | | OK |
LOC: | 67 | | OK |
--------------+---------+-------+---------+
metrics are OK
plot_line (Begins at: 334 Ends at: 403)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 3 | | OK |
LOC: | 70 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
nearest (Begins at: 414 Ends at: 435)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_polygon (Begins at: 437 Ends at: 573)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 3 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 137 | * | |
--------------+---------+-------+---------+
metrics are OK
G_plot_area (Begins at: 575 Ends at: 700)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 126 | * | |
--------------+---------+-------+---------+
metrics are OK
edge (Begins at: 702 Ends at: 739)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
edge_point (Begins at: 741 Ends at: 767)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
edge_order (Begins at: 769 Ends at: 779)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
row_solid_fill (Begins at: 781 Ends at: 794)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
row_dotted_fill (Begins at: 796 Ends at: 815)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
ifloor (Begins at: 817 Ends at: 823)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
iceil (Begins at: 825 Ends at: 850)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_plot_fx (Begins at: 852 Ends at: 888)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list