[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/fpreclass.c |13 clones ( cats.c color_read.c find_cell.c find_vect.c fpreclass.c )| 0 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 14 19:38:23 EDT 2007



Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/fpreclass.c functions


G_fpreclass_clear (Begins at: 263 Ends at: 270)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_reset (Begins at: 275 Ends at: 283)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_init (Begins at: 287 Ends at: 294)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_set_domain (Begins at: 299 Ends at: 305)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_set_range (Begins at: 310 Ends at: 316)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fpreclass_set_limits (Begins at: 321 Ends at: 328)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fpreclass_update_limits (Begins at: 333 Ends at: 345)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_get_limits (Begins at: 350 Ends at: 371)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_nof_rules (Begins at: 376 Ends at: 380)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_get_ith_rule (Begins at: 385 Ends at: 392)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fpreclass_table_increase (Begins at: 397 Ends at: 411)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_set_neg_infinite_rule (Begins at: 416 Ends at: 423)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_get_neg_infinite_rule (Begins at: 428 Ends at: 437)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_set_pos_infinite_rule (Begins at: 442 Ends at: 449)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_get_pos_infinite_rule (Begins at: 454 Ends at: 463)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_add_rule (Begins at: 468 Ends at: 488)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_reverse_rule_order (Begins at: 493 Ends at: 514)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fpreclass_interpolate (Begins at: 519 Ends at: 526)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

fpreclass_get_default_cell_value (Begins at: 531 Ends at: 546)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_get_cell_value (Begins at: 551 Ends at: 577)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_di (Begins at: 582 Ends at: 592)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_df (Begins at: 597 Ends at: 607)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_dd (Begins at: 612 Ends at: 622)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_fi (Begins at: 627 Ends at: 637)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_ff (Begins at: 642 Ends at: 652)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_fd (Begins at: 657 Ends at: 667)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_ii (Begins at: 672 Ends at: 682)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_if (Begins at: 687 Ends at: 697)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpreclass_perform_id (Begins at: 702 Ends at: 712)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 13 potentially cloned functions:
  G_fpreclass_set_pos_infinite_rule  G_fpreclass_set_neg_infinite_rule  G_fpreclass_get_pos_infinite_rule  G_fpreclass_get_neg_infinite_rule  G_fpreclass_perform_id  G_fpreclass_perform_if  G_fpreclass_perform_ii  G_fpreclass_perform_fd  G_fpreclass_perform_ff  G_fpreclass_perform_fi  G_fpreclass_perform_dd  G_fpreclass_perform_df  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_di are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df

In lib/gis/fpreclass.c clones of  G_fpreclass_set_neg_infinite_rule are:
	lib/gis/fpreclass.c  G_fpreclass_set_pos_infinite_rule

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_df are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_ff are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_id are:
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_set_pos_infinite_rule are:
	lib/gis/fpreclass.c  G_fpreclass_set_neg_infinite_rule

In lib/gis/fpreclass.c clones of  G_fpreclass_get_neg_infinite_rule are:
	lib/gis/fpreclass.c  G_fpreclass_get_pos_infinite_rule

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_ii are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_dd are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_get_pos_infinite_rule are:
	lib/gis/fpreclass.c  G_fpreclass_get_neg_infinite_rule

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_if are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_fi are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_fd
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di

In lib/gis/fpreclass.c clones of  G_fpreclass_perform_fd are:
	lib/gis/fpreclass.c  G_fpreclass_perform_id
	lib/gis/fpreclass.c  G_fpreclass_perform_if
	lib/gis/fpreclass.c  G_fpreclass_perform_ii
	lib/gis/fpreclass.c  G_fpreclass_perform_ff
	lib/gis/fpreclass.c  G_fpreclass_perform_fi
	lib/gis/fpreclass.c  G_fpreclass_perform_dd
	lib/gis/fpreclass.c  G_fpreclass_perform_df
	lib/gis/fpreclass.c  G_fpreclass_perform_di


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list