[GRASS-QA] GRASS QA: glynn | ./grass6/raster/r.li/r.li.padrange/padrange.c |1 clones ( input.c georef.c ask.c fpcompress.c g3derror.c padrange.c )| 6 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Sun Apr 15 17:07:54 EDT 2007



Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.li/r.li.padrange/padrange.c functions


main (Begins at: 31 Ends at: 53)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

patchAreaDistributionRANGE (Begins at: 54 Ends at: 98)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      45 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

calculate (Begins at: 101 Ends at: 542)
--------------+---------+-------+---------+
Complexity:   |      56 |   *** | MONSTER |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      47 |     * |         |
LOC:          |     442 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

calculateD (Begins at: 546 Ends at: 971)
--------------+---------+-------+---------+
Complexity:   |      56 |   *** | MONSTER |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      47 |     * |         |
LOC:          |     426 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

calculateF (Begins at: 975 Ends at: 1405)
--------------+---------+-------+---------+
Complexity:   |      56 |   *** | MONSTER |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      47 |     * |         |
LOC:          |     431 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

Clone analysis:

This file has 1 potentially cloned functions:
  main

In raster/r.li/r.li.padrange/padrange.c clones of  main are:
	raster/r.li/r.li.padsd/padsd.c  main
	raster/r.li/r.li.padcv/padcv.c  main


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list