[GRASS-QA] GRASS QA: glynn | ./grass6/raster/r.le/r.le.pixel/texture.c |no clones | 5 monsters | 4 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.le/r.le.pixel/texture.c functions


mv_texture (Begins at: 56 Ends at: 238)
--------------+---------+-------+---------+
Complexity:   |      32 |    ** | Warning |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |      19 |       |      OK |
LOC:          |     183 |     * |         |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

df_texture (Begins at: 246 Ends at: 587)
--------------+---------+-------+---------+
Complexity:   |      47 |   *** | MONSTER |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      85 |    ** | Warning |
LOC:          |     342 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

cal_att (Begins at: 595 Ends at: 648)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      54 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

cal_divers (Begins at: 655 Ends at: 730)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       4 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

cal_tex (Begins at: 732 Ends at: 891)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      14 |       |      OK |
LOC:          |     160 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

cal_edge (Begins at: 897 Ends at: 1179)
--------------+---------+-------+---------+
Complexity:   |      35 |    ** | Warning |
ParamNBR:     |      15 |   *** | MONSTER |
CalledNBR:    |      14 |       |      OK |
LOC:          |     283 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

read_weight (Begins at: 1186 Ends at: 1239)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      54 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_edge (Begins at: 1241 Ends at: 1298)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      58 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_loc (Begins at: 1300 Ends at: 1319)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_edge (Begins at: 1321 Ends at: 1335)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

check_order (Begins at: 1343 Ends at: 1351)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html