[GRASS-QA] GRASS QA: glynn | ./grass6/lib/vector/diglib/plus_struct.c |no clones | 0 monsters | 4 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/diglib/plus_struct.c functions


dig_Rd_P_node (Begins at: 52 Ends at: 106)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      55 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_Wr_P_node (Begins at: 109 Ends at: 156)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      48 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_Rd_P_line (Begins at: 159 Ends at: 241)
--------------+---------+-------+---------+
Complexity:   |      27 |    ** | Warning |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      21 |       |      OK |
LOC:          |      83 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

dig_Wr_P_line (Begins at: 244 Ends at: 313)
--------------+---------+-------+---------+
Complexity:   |      27 |    ** | Warning |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      21 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

dig_Rd_P_area (Begins at: 316 Ends at: 372)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_Wr_P_area (Begins at: 375 Ends at: 417)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_Rd_P_isle (Begins at: 420 Ends at: 467)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      48 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_Wr_P_isle (Begins at: 470 Ends at: 507)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_Rd_Plus_head (Begins at: 514 Ends at: 606)
--------------+---------+-------+---------+
Complexity:   |      33 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      41 |     * |         |
LOC:          |      93 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

dig_Wr_Plus_head (Begins at: 609 Ends at: 673)
--------------+---------+-------+---------+
Complexity:   |      31 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      34 |       |      OK |
LOC:          |      65 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html