[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/timestamp.c |3 clones
( orig_wind.c get_row.c range.c timestamp.c )| 0 monsters | 0
warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sun Apr 15 23:22:20 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/timestamp.c functions
G_init_timestamp (Begins at: 99 Ends at: 102)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_timestamp (Begins at: 104 Ends at: 108)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_timestamp_range (Begins at: 110 Ends at: 117)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__read_timestamp (Begins at: 119 Ends at: 145)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__write_timestamp (Begins at: 147 Ends at: 171)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_format_timestamp (Begins at: 173 Ends at: 210)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_scan_timestamp (Begins at: 212 Ends at: 259)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 48 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_timestamps (Begins at: 261 Ends at: 279)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
write_timestamp (Begins at: 287 Ends at: 311)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_timestamp (Begins at: 319 Ends at: 362)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 8 | | OK |
LOC: | 44 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_raster_timestamp (Begins at: 364 Ends at: 382)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_remove_raster_timestamp (Begins at: 384 Ends at: 401)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_vector_timestamp (Begins at: 403 Ends at: 424)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_remove_vector_timestamp (Begins at: 426 Ends at: 441)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_grid3_timestamp (Begins at: 443 Ends at: 461)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_remove_grid3_timestamp (Begins at: 463 Ends at: 480)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_raster_timestamp (Begins at: 482 Ends at: 501)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_vector_timestamp (Begins at: 503 Ends at: 521)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_grid3_timestamp (Begins at: 523 Ends at: 528)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 3 potentially cloned functions:
G_remove_vector_timestamp G_read_grid3_timestamp G_read_raster_timestamp
In lib/gis/timestamp.c clones of G_read_raster_timestamp are:
lib/gis/timestamp.c G_read_grid3_timestamp
In lib/gis/timestamp.c clones of G_remove_vector_timestamp are:
lib/gis/range.c G__remove_fp_range
In lib/gis/timestamp.c clones of G_read_grid3_timestamp are:
lib/gis/timestamp.c G_read_raster_timestamp
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list