[GRASS-QA] GRASS QA: glynn | ./grass6/raster/r.drain/resolve.c |2 clones ( write.c write.c resolve.c )| 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.drain/resolve.c functions


select_dir (Begins at: 6 Ends at: 30)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

flink (Begins at: 32 Ends at: 88)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       2 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

resolve (Begins at: 90 Ends at: 204)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |     115 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  flink  select_dir

In raster/r.drain/resolve.c clones of  select_dir are:
	raster/r.fill.dir/resolve.c  select_dir

In raster/r.drain/resolve.c clones of  flink are:
	raster/r.fill.dir/resolve.c  flink


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-16 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html