[GRASS-QA] GRASS QA: glynn | ./grass6/raster/r.drain/tinf.c |1
clones ( write.c write.c resolve.c tinf.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Mon Apr 16 16:44:20 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster/r.drain/tinf.c functions
set_func_pointers (Begins at: 13 Ends at: 76)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 64 | | OK |
--------------+---------+-------+---------+
metrics are OK
is_null_c (Begins at: 79 Ends at: 79)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
is_null_f (Begins at: 80 Ends at: 80)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
is_null_d (Begins at: 81 Ends at: 81)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_null_value_c (Begins at: 84 Ends at: 84)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_null_value_f (Begins at: 85 Ends at: 85)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_null_value_d (Begins at: 86 Ends at: 86)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
bpe_c (Begins at: 89 Ends at: 89)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
bpe_f (Begins at: 90 Ends at: 90)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
bpe_d (Begins at: 91 Ends at: 91)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_min_c (Begins at: 94 Ends at: 101)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_min_f (Begins at: 103 Ends at: 110)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_min_d (Begins at: 112 Ends at: 119)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_max_c (Begins at: 122 Ends at: 129)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_max_f (Begins at: 131 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_max_d (Begins at: 140 Ends at: 147)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_row_c (Begins at: 150 Ends at: 153)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_row_f (Begins at: 155 Ends at: 158)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_row_d (Begins at: 160 Ends at: 163)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_row_c (Begins at: 166 Ends at: 169)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_row_f (Begins at: 171 Ends at: 174)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
put_row_d (Begins at: 176 Ends at: 179)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_buf_c (Begins at: 182 Ends at: 185)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_buf_f (Begins at: 187 Ends at: 190)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_buf_d (Begins at: 192 Ends at: 195)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_min_c (Begins at: 198 Ends at: 198)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_min_f (Begins at: 199 Ends at: 199)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_min_d (Begins at: 200 Ends at: 200)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_max_c (Begins at: 203 Ends at: 203)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_max_f (Begins at: 204 Ends at: 204)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_max_d (Begins at: 205 Ends at: 205)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
diff_c (Begins at: 208 Ends at: 208)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
diff_f (Begins at: 209 Ends at: 209)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
diff_d (Begins at: 210 Ends at: 210)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
sum_c (Begins at: 213 Ends at: 213)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
sum_f (Begins at: 214 Ends at: 214)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
sum_d (Begins at: 215 Ends at: 215)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
quot_c (Begins at: 218 Ends at: 218)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
quot_f (Begins at: 219 Ends at: 219)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
quot_d (Begins at: 220 Ends at: 220)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
prod_c (Begins at: 223 Ends at: 223)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
prod_f (Begins at: 224 Ends at: 224)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
prod_d (Begins at: 225 Ends at: 225)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
slope_c (Begins at: 229 Ends at: 241)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
slope_f (Begins at: 243 Ends at: 255)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
slope_d (Begins at: 257 Ends at: 269)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
advance_band3 (Begins at: 273 Ends at: 285)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
retreat_band3 (Begins at: 289 Ends at: 305)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
retreat_band3
In raster/r.drain/tinf.c clones of retreat_band3 are:
raster/r.fill.dir/tinf.c retreat_band3
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-16 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list