[GRASS-QA] GRASS QA: markus |
./grass6/vector/lidar/lidarlib/InterpSpline.c |no clones | 4
monsters | 2 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Mon Apr 16 17:48:29 EDT 2007
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
vector/lidar/lidarlib/InterpSpline.c functions
node_x (Begins at: 30 Ends at: 36)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
node_y (Begins at: 41 Ends at: 47)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
order (Begins at: 52 Ends at: 55)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_3 (Begins at: 60 Ends at: 63)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_4 (Begins at: 65 Ends at: 68)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_33 (Begins at: 70 Ends at: 73)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_34 (Begins at: 75 Ends at: 78)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_43 (Begins at: 80 Ends at: 83)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_44 (Begins at: 85 Ends at: 88)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi (Begins at: 90 Ends at: 93)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
normalDefBicubic (Begins at: 98 Ends at: 174)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 13 | *** | MONSTER |
CalledNBR: | 22 | | OK |
LOC: | 77 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
nCorrectLapl (Begins at: 180 Ends at: 253)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 3 | | OK |
LOC: | 74 | | OK |
--------------+---------+-------+---------+
metrics are OK
normalDefBilin (Begins at: 258 Ends at: 354)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 13 | *** | MONSTER |
CalledNBR: | 10 | | OK |
LOC: | 97 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
nCorrectGrad (Begins at: 356 Ends at: 384)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 0 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
obsEstimateBicubic (Begins at: 389 Ends at: 443)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 19 | | OK |
LOC: | 55 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
dataInterpolateBicubic (Begins at: 449 Ends at: 500)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 19 | | OK |
LOC: | 52 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
obsEstimateBilin (Begins at: 506 Ends at: 545)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 7 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
dataInterpolateBilin (Begins at: 551 Ends at: 587)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 7 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-16 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list