[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.le/r.le.setup/sample.c |no clones | 8 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.le/r.le.setup/sample.c functions


sample (Begins at: 52 Ends at: 116)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      16 |       |      OK |
LOC:          |      65 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

man_unit (Begins at: 122 Ends at: 654)
--------------+---------+-------+---------+
Complexity:   |      57 |   *** | MONSTER |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |     155 |   *** | MONSTER |
LOC:          |     533 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

draw_grid (Begins at: 659 Ends at: 720)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       8 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

calc_unit_loc (Begins at: 725 Ends at: 961)
--------------+---------+-------+---------+
Complexity:   |      28 |    ** | Warning |
ParamNBR:     |      22 |   *** | MONSTER |
CalledNBR:    |      44 |     * |         |
LOC:          |     237 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

get_rd (Begins at: 966 Ends at: 978)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

f (Begins at: 983 Ends at: 988)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

overlap (Begins at: 993 Ends at: 999)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

calc_num (Begins at: 1004 Ends at: 1030)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |      11 |   *** | MONSTER |
CalledNBR:    |       4 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

graph_unit (Begins at: 1038 Ends at: 1433)
--------------+---------+-------+---------+
Complexity:   |      35 |    ** | Warning |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |     117 |   *** | MONSTER |
LOC:          |     396 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

draw_box (Begins at: 1438 Ends at: 1467)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      11 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_circle (Begins at: 1472 Ends at: 1512)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       7 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

numtrap (Begins at: 1517 Ends at: 1585)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      69 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-24 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html