[GRASS-QA] GRASS QA: markus | ./grass6/imagery/i.class/input.c |6
clones ( graphics.c input.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sun Aug 5 06:49:39 EDT 2007
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
imagery/i.class/input.c functions
Input_pointer (Begins at: 21 Ends at: 24)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Input_box (Begins at: 27 Ends at: 30)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Input_other (Begins at: 33 Ends at: 46)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
mouse (Begins at: 48 Ends at: 103)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
use_mouse_msg (Begins at: 107 Ends at: 112)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
draw_objects (Begins at: 114 Ends at: 178)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 16 | | OK |
LOC: | 65 | | OK |
--------------+---------+-------+---------+
metrics are OK
find (Begins at: 180 Ends at: 202)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
select_option (Begins at: 204 Ends at: 216)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
draw_option_boxes (Begins at: 218 Ends at: 236)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
visible (Begins at: 238 Ends at: 243)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Menu_msg (Begins at: 246 Ends at: 266)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Start_mouse_in_menu (Begins at: 269 Ends at: 276)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
select_option find draw_option_boxes Input_other mouse draw_objects
In imagery/i.class/input.c clones of select_option are:
imagery/i.vpoints/input.c select_option
imagery/i.points/input.c select_option
imagery/i.ortho.photo/photo.2target/input.c select_option
imagery/i.ortho.photo/photo.2image/input.c select_option
In imagery/i.class/input.c clones of mouse are:
imagery/i.points/input.c mouse
imagery/i.ortho.photo/photo.2image/input.c mouse
In imagery/i.class/input.c clones of draw_option_boxes are:
imagery/i.ortho.photo/photo.2target/input.c draw_option_boxes
imagery/i.ortho.photo/photo.2image/input.c draw_option_boxes
In imagery/i.class/input.c clones of draw_objects are:
imagery/i.vpoints/input.c draw_objects
imagery/i.points/input.c draw_objects
imagery/i.ortho.photo/photo.2target/input.c draw_objects
imagery/i.ortho.photo/photo.2image/input.c draw_objects
In imagery/i.class/input.c clones of find are:
imagery/i.vpoints/input.c find
imagery/i.points/input.c find
imagery/i.ortho.photo/photo.2target/input.c find
imagery/i.ortho.photo/photo.2image/input.c find
In imagery/i.class/input.c clones of Input_other are:
imagery/i.ortho.photo/photo.2image/input.c Input_other
__________________________________________
Threshold GRASS6 key metrics values at 2007-08-05 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 88 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list