[GRASS-QA] GRASS QA: brad | ./grass6/raster/r.flow/precomp.c |no clones | 1 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.flow/precomp.c functions


precompute_tangents (Begins at: 36 Ends at: 44)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

precompute_ew_dists (Begins at: 47 Ends at: 64)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

precompute_epsilons (Begins at: 67 Ends at: 100)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

upslope_correction (Begins at: 103 Ends at: 122)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      39 |     * |         |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

interpolate_border (Begins at: 125 Ends at: 144)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |     144 |   *** | MONSTER |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

reflect_and_sentinel (Begins at: 147 Ends at: 161)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      31 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

precompute_aspects (Begins at: 164 Ends at: 186)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      17 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

precompute (Begins at: 189 Ends at: 219)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-02-07 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html