[GRASS-QA] GRASS QA: glynn | ./grass6/lib/raster/loc_proto.c |9
clones ( com_proto.c loc_proto.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sun Feb 11 16:58:05 EST 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/raster/loc_proto.c functions
LOC_screen_left (Begins at: 25 Ends at: 41)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_screen_rite (Begins at: 43 Ends at: 59)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_screen_bot (Begins at: 61 Ends at: 78)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_screen_top (Begins at: 80 Ends at: 87)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_get_num_colors (Begins at: 89 Ends at: 102)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_color (Begins at: 104 Ends at: 119)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_standard_color (Begins at: 121 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_RGB_color (Begins at: 140 Ends at: 156)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_reset_color (Begins at: 158 Ends at: 180)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_reset_colors (Begins at: 182 Ends at: 195)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_line_width (Begins at: 197 Ends at: 209)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_erase (Begins at: 211 Ends at: 225)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_move_abs (Begins at: 227 Ends at: 245)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_move_rel (Begins at: 247 Ends at: 262)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_cont_abs (Begins at: 264 Ends at: 284)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_cont_rel (Begins at: 286 Ends at: 302)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polydots_abs (Begins at: 304 Ends at: 322)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polydots_rel (Begins at: 324 Ends at: 343)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polyline_abs (Begins at: 345 Ends at: 365)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polyline_rel (Begins at: 367 Ends at: 383)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polygon_abs (Begins at: 385 Ends at: 403)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_polygon_rel (Begins at: 405 Ends at: 422)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_box_abs (Begins at: 424 Ends at: 440)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_box_rel (Begins at: 442 Ends at: 455)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_text_size (Begins at: 457 Ends at: 460)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_text_rotation (Begins at: 462 Ends at: 478)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_set_window (Begins at: 480 Ends at: 493)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_text (Begins at: 495 Ends at: 515)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_get_text_box (Begins at: 517 Ends at: 552)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_font (Begins at: 554 Ends at: 557)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_font_freetype (Begins at: 559 Ends at: 562)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_charset (Begins at: 564 Ends at: 567)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_font_freetype_release (Begins at: 569 Ends at: 572)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_panel_save (Begins at: 574 Ends at: 580)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 4 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_panel_restore (Begins at: 582 Ends at: 586)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_panel_delete (Begins at: 588 Ends at: 610)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_set_RGB_color (Begins at: 612 Ends at: 638)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_RGB_raster (Begins at: 640 Ends at: 676)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_raster_char (Begins at: 678 Ends at: 681)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_raster_int (Begins at: 683 Ends at: 686)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
LOC_bitmap (Begins at: 688 Ends at: 691)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 9 potentially cloned functions:
LOC_set_window LOC_cont_rel LOC_get_text_box LOC_RGB_raster LOC_box_abs LOC_reset_colors LOC_screen_rite LOC_screen_left LOC_text
In lib/raster/loc_proto.c clones of LOC_cont_rel are:
lib/raster/com_proto.c R_cont_rel
In lib/raster/loc_proto.c clones of LOC_RGB_raster are:
lib/raster/com_proto.c R_RGB_raster
In lib/raster/loc_proto.c clones of LOC_get_text_box are:
lib/raster/com_proto.c R_get_text_box
In lib/raster/loc_proto.c clones of LOC_reset_colors are:
lib/raster/com_proto.c R_reset_colors
In lib/raster/loc_proto.c clones of LOC_text are:
lib/raster/com_proto.c R_text
In lib/raster/loc_proto.c clones of LOC_screen_rite are:
lib/raster/loc_proto.c LOC_screen_left
In lib/raster/loc_proto.c clones of LOC_set_window are:
lib/raster/com_proto.c R_set_window
In lib/raster/loc_proto.c clones of LOC_box_abs are:
lib/raster/com_proto.c R_box_abs
In lib/raster/loc_proto.c clones of LOC_screen_left are:
lib/raster/loc_proto.c LOC_screen_rite
__________________________________________
Threshold GRASS6 key metrics values at 2007-02-11 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list