[GRASS-QA] GRASS QA: danielc | ./grass6/lib/gis/parser.c |no clones
| 1 monsters | 9 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Mon Jun 25 03:59:38 EDT 2007
Hello danielc,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/parser.c functions
G_disable_interactive (Begins at: 161 Ends at: 182)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_flag (Begins at: 185 Ends at: 243)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 59 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_option (Begins at: 246 Ends at: 328)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 83 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_standard_option (Begins at: 331 Ends at: 602)
--------------+---------+-------+---------+
Complexity: | 31 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 36 | * | |
LOC: | 272 | *** | MONSTER |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
G_define_module (Begins at: 605 Ends at: 657)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_parser (Begins at: 659 Ends at: 925)
--------------+---------+-------+---------+
Complexity: | 37 | *** | MONSTER |
ParamNBR: | 2 | | OK |
CalledNBR: | 74 | ** | Warning |
LOC: | 267 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
uses_new_gisprompt (Begins at: 928 Ends at: 978)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_usage (Begins at: 980 Ends at: 1166)
--------------+---------+-------+---------+
Complexity: | 33 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 53 | * | |
LOC: | 187 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
print_escaped_for_xml (Begins at: 1168 Ends at: 1184)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
print_escaped_for_html (Begins at: 1191 Ends at: 1202)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_usage_xml (Begins at: 1205 Ends at: 1419)
--------------+---------+-------+---------+
Complexity: | 28 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 71 | ** | Warning |
LOC: | 215 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
G_usage_html (Begins at: 1421 Ends at: 1647)
--------------+---------+-------+---------+
Complexity: | 42 | *** | MONSTER |
ParamNBR: | 1 | | OK |
CalledNBR: | 85 | ** | Warning |
LOC: | 227 | ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
G_script (Begins at: 1649 Ends at: 1760)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 46 | * | |
LOC: | 112 | | OK |
--------------+---------+-------+---------+
metrics are OK
generate_tcl (Begins at: 1762 Ends at: 1857)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 45 | * | |
LOC: | 96 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_gui (Begins at: 1860 Ends at: 1889)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_tcltk (Begins at: 1892 Ends at: 1907)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
show_options (Begins at: 1909 Ends at: 1939)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
show (Begins at: 1941 Ends at: 1954)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_flag (Begins at: 1956 Ends at: 1983)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
contains (Begins at: 1988 Ends at: 1997)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_option (Begins at: 1999 Ends at: 2059)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 61 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_opts (Begins at: 2061 Ends at: 2098)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_an_opt (Begins at: 2100 Ends at: 2142)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_int (Begins at: 2144 Ends at: 2210)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 67 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_double (Begins at: 2212 Ends at: 2252)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_string (Begins at: 2254 Ends at: 2281)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_required (Begins at: 2283 Ends at: 2306)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
split_opts (Begins at: 2308 Ends at: 2371)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 64 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_multiple_opts (Begins at: 2373 Ends at: 2411)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 39 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_overwrite (Begins at: 2414 Ends at: 2470)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive (Begins at: 2472 Ends at: 2500)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive_flag (Begins at: 2502 Ends at: 2510)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive_option (Begins at: 2512 Ends at: 2602)
--------------+---------+-------+---------+
Complexity: | 23 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 41 | * | |
LOC: | 91 | | OK |
--------------+---------+-------+---------+
metrics are OK
split_gisprompt (Begins at: 2604 Ends at: 2634)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
gis_prompt (Begins at: 2636 Ends at: 2693)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 20 | | OK |
LOC: | 58 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_recreate_command (Begins at: 2695 Ends at: 2797)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 25 | | OK |
LOC: | 103 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-06-25 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list