[GRASS-QA] GRASS QA: glynn | ./grass6/lib/display/raster_rgb.c |3 clones ( curses.c graphics.c mouse.c signature.c plot.c main.c main.c main.c main.c main.c main.c graphics.c graphics.c graphics.c graphics.c graphics.c c_update.c d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c raster_rgb.c raster_rgb.c )| 3 monsters | 4 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/display/raster_rgb.c functions


D_draw_raster_RGB (Begins at: 48 Ends at: 58)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

D_draw_d_raster_RGB (Begins at: 60 Ends at: 69)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

D_draw_f_raster_RGB (Begins at: 71 Ends at: 80)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

D_draw_c_raster_RGB (Begins at: 82 Ends at: 91)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

D_draw_cell_RGB (Begins at: 93 Ends at: 102)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

draw_cell_RGB (Begins at: 104 Ends at: 191)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      19 |       |      OK |
LOC:          |      88 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

D_cell_draw_setup_RGB (Begins at: 193 Ends at: 236)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      44 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_raster_of_type_RGB (Begins at: 238 Ends at: 284)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |      11 |   *** | MONSTER |
CalledNBR:    |      17 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

D_set_colors_RGB (Begins at: 286 Ends at: 295)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  D_draw_c_raster_RGB  D_draw_f_raster_RGB  D_draw_d_raster_RGB

In lib/display/raster_rgb.c clones of  D_draw_d_raster_RGB are:
	lib/display/raster_rgb.c  D_draw_c_raster_RGB
	lib/display/raster_rgb.c  D_draw_f_raster_RGB

In lib/display/raster_rgb.c clones of  D_draw_f_raster_RGB are:
	lib/display/raster_rgb.c  D_draw_c_raster_RGB
	lib/display/raster_rgb.c  D_draw_d_raster_RGB

In lib/display/raster_rgb.c clones of  D_draw_c_raster_RGB are:
	lib/display/raster_rgb.c  D_draw_f_raster_RGB
	lib/display/raster_rgb.c  D_draw_d_raster_RGB


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html