[GRASS-QA] GRASS QA: soeren | ./grass6/lib/g3d/g3dmisc.c |4 clones ( curses.c graphics.c mouse.c signature.c plot.c main.c main.c main.c main.c main.c main.c graphics.c graphics.c graphics.c graphics.c graphics.c c_update.c d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c raster_rgb.c raster_rgb.c Get_location.c com_proto.c com_proto.c com_proto.c loc_proto.c loc_proto.c loc_proto.c i_face.c main.c main.c level_two.c main.c build.c line.c read_nat.c areas.c filecompare.c g3dfpxdr.c g3dmisc.c )| 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/g3d/g3dmisc.c functions


G3d_g3dType2cellType (Begins at: 12 Ends at: 17)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_copyFloat2Double (Begins at: 22 Ends at: 31)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_copyDouble2Float (Begins at: 36 Ends at: 45)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_copyValues (Begins at: 50 Ends at: 75)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       3 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G3d_length (Begins at: 80 Ends at: 88)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_externLength (Begins at: 91 Ends at: 99)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  G3d_externLength  G3d_length  G3d_copyDouble2Float  G3d_copyFloat2Double

In lib/g3d/g3dmisc.c clones of  G3d_copyDouble2Float are:
	lib/g3d/g3dmisc.c  G3d_copyFloat2Double

In lib/g3d/g3dmisc.c clones of  G3d_length are:
	lib/g3d/g3dmisc.c  G3d_externLength

In lib/g3d/g3dmisc.c clones of  G3d_copyFloat2Double are:
	lib/g3d/g3dmisc.c  G3d_copyDouble2Float

In lib/g3d/g3dmisc.c clones of  G3d_externLength are:
	lib/g3d/g3dmisc.c  G3d_length


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html